-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to WAF v5 docs #6694
Updates to WAF v5 docs #6694
Conversation
✅ Deploy Preview will be available once build job completes!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Minor nitpick: Helm is the name of the software. We capitalise it each time unless we're talking about the actual binary command, helm
.
site/content/installation/integrations/app-protect-waf-v5/installation.md
Outdated
Show resolved
Hide resolved
site/content/installation/integrations/app-protect-waf-v5/installation.md
Outdated
Show resolved
Hide resolved
site/content/installation/integrations/app-protect-waf-v5/installation.md
Outdated
Show resolved
Hide resolved
site/content/installation/integrations/app-protect-waf-v5/installation.md
Outdated
Show resolved
Hide resolved
site/content/installation/integrations/app-protect-waf-v5/installation.md
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6694 +/- ##
=======================================
Coverage 53.38% 53.38%
=======================================
Files 89 89
Lines 20195 20195
=======================================
Hits 10781 10781
Misses 8977 8977
Partials 437 437 ☔ View full report in Codecov by Sentry. |
Proposed changes
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
that issue here in this description (not in the title of the PR).
Checklist
Before creating a PR, run through this checklist and mark each as complete.