Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to WAF v5 docs #6694

Merged
merged 27 commits into from
Nov 13, 2024
Merged

Updates to WAF v5 docs #6694

merged 27 commits into from
Nov 13, 2024

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Oct 21, 2024

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Oct 21, 2024
@jjngx jjngx linked an issue Oct 21, 2024 that may be closed by this pull request
2 tasks
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/6694/

@jjngx jjngx marked this pull request as ready for review October 22, 2024 08:20
@jjngx jjngx requested review from a team as code owners October 22, 2024 08:20
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Minor nitpick: Helm is the name of the software. We capitalise it each time unless we're talking about the actual binary command, helm.

site/content/configuration/security.md Outdated Show resolved Hide resolved
site/content/configuration/security.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.38%. Comparing base (f9b5ce5) to head (67176a3).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6694   +/-   ##
=======================================
  Coverage   53.38%   53.38%           
=======================================
  Files          89       89           
  Lines       20195    20195           
=======================================
  Hits        10781    10781           
  Misses       8977     8977           
  Partials      437      437           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jjngx jjngx merged commit d60a6c6 into main Nov 13, 2024
30 checks passed
@jjngx jjngx deleted the docs/waf-v5-docs branch November 13, 2024 10:48
@pdabelf5 pdabelf5 changed the title Docs/waf v5 docs Updates to WAF v5 docs Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

Update documentation for readOnlyRootFilesystem to include setting for WAF v5
4 participants