Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update python to 3.13 and disable pytest-profiling #6651

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Update python to 3.13 and disable pytest-profiling #6651

merged 4 commits into from
Oct 15, 2024

Conversation

AlexFenlon
Copy link
Contributor

@AlexFenlon AlexFenlon commented Oct 14, 2024 •
edited
Loading

Proposed changes

  • update python to 3.13
  • remove pytest-profiling temporarily

It is removed due to python version 3.13 deprecating the pipes module which is required for pytest-profiling. Disabling for now until pytests has a alternative.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added python Pull requests that update Python code docker Pull requests that update Docker code labels Oct 14, 2024
@AlexFenlon AlexFenlon closed this Oct 14, 2024
@AlexFenlon AlexFenlon reopened this Oct 14, 2024
@github-actions github-actions bot added the chore Pull requests for routine tasks label Oct 14, 2024
@AlexFenlon
Update python typo
f5b33a0 
Signed-off-by: AlexFenlon <[email protected]>
@AlexFenlon AlexFenlon marked this pull request as ready for review October 15, 2024 08:47
@AlexFenlon AlexFenlon requested a review from a team as a code owner October 15, 2024 08:47
@AlexFenlon AlexFenlon changed the title [DRAFT] update python to 3.13 and disable pytest-profiling Update python to 3.13 and disable pytest-profiling Oct 15, 2024
@jjngx jjngx merged commit 9a48996 into main Oct 15, 2024
83 checks passed
@jjngx jjngx deleted the test/update-python branch October 15, 2024 09:13
@AlexFenlon AlexFenlon mentioned this pull request Oct 15, 2024
Merged
6 tasks
@vepatel vepatel mentioned this pull request Oct 18, 2024
Merged
6 tasks
@pdabelf5 pdabelf5 removed python Pull requests that update Python code docker Pull requests that update Docker code labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j1m-ryan j1m-ryan j1m-ryan left review comments

@jjngx jjngx jjngx approved these changes

@vepatel vepatel vepatel approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AlexFenlon @j1m-ryan @vepatel @jjngx @pdabelf5