Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace glog in healthcheck.go & remove glog dependency #6628

Merged
merged 17 commits into from
Oct 10, 2024

Conversation

AlexFenlon
Copy link
Contributor

Proposed changes

  • Replacedglog with slog in healthcheck.go
  • Completely remove glog from the project - removed from go.mod & go.sum

NOTE:

GLog Levels Slog Levels
glog.V(3).Infof() log.Debugf()
glog.V(3).Info() log.Debug()
glog.V(2).Infof() log.Debugf()
glog.V(2).Info() log.Debug()
glog.Infof() log.Infof()
glog.Info() log.Info()
glog.Warningf() log.Warnf()
glog.Warning() log.Warn()
glog.Errorf() log.Errorf()
glog.Error() log.Error()
glog.Fatalf() log.Fatalf()
glog.Fatal() log.Fatal()

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon requested review from a team as code owners October 9, 2024 13:06
@AlexFenlon AlexFenlon self-assigned this Oct 9, 2024
@github-actions github-actions bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Oct 9, 2024
@AlexFenlon AlexFenlon removed the request for review from a team October 9, 2024 13:06
Copy link

github-actions bot commented Oct 9, 2024

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/6628/

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 23.07692% with 10 lines in your changes missing coverage. Please review.

Project coverage is 53.26%. Comparing base (8cfa485) to head (7c280ac).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/healthcheck/healthcheck.go 23.07% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6628      +/-   ##
==========================================
+ Coverage   53.24%   53.26%   +0.01%     
==========================================
  Files          87       87              
  Lines       16263    16259       -4     
==========================================
  Hits         8660     8660              
+ Misses       7188     7184       -4     
  Partials      415      415              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexFenlon AlexFenlon mentioned this pull request Oct 9, 2024
16 tasks
@AlexFenlon AlexFenlon changed the title refactor: replace glog in healthcheck.go refactor: replace glog in healthcheck.go & remove glog dependency Oct 9, 2024
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@AlexFenlon AlexFenlon merged commit ec22bcf into main Oct 10, 2024
79 checks passed
@AlexFenlon AlexFenlon deleted the chore/refactor-healthcheck-glog branch October 10, 2024 14:40
@AlexFenlon AlexFenlon removed the dependencies Pull requests that update a dependency file label Oct 10, 2024
@pdabelf5 pdabelf5 added chore Pull requests for routine tasks and removed go Pull requests that update Go code labels Dec 16, 2024
@pdabelf5 pdabelf5 changed the title refactor: replace glog in healthcheck.go & remove glog dependency Replace glog in healthcheck.go & remove glog dependency Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants