Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed note mentioning R33 from NIC RNs. #6623

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

travisamartin
Copy link
Contributor

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@travisamartin travisamartin requested review from a team as code owners October 8, 2024 23:24
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Oct 8, 2024
Copy link

github-actions bot commented Oct 8, 2024

🎉 Thank you for your contribution! It appears you have not yet signed the F5 Contributor License Agreement (CLA), which is required for your changes to be incorporated into an F5 Open Source Software (OSS) project. Please kindly read the F5 CLA and reply on a new comment with the following text to agree:


I have hereby read the F5 CLA and agree to its terms


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copy link

github-actions bot commented Oct 8, 2024

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/6623/

@travisamartin travisamartin added the needs cherry pick Cherry pick this PR into a release branch label Oct 8, 2024
@LukeBillington LukeBillington self-requested a review October 8, 2024 23:29
@travisamartin travisamartin self-assigned this Oct 8, 2024
@travisamartin travisamartin merged commit 8cfa485 into main Oct 8, 2024
29 of 30 checks passed
@travisamartin travisamartin deleted the nic-rns-remove-r33-note branch October 8, 2024 23:31
travisamartin added a commit that referenced this pull request Oct 8, 2024
Removed note mentioning R33 from NIC RNs. (#6623)

Co-authored-by: Travis Martin <[email protected]>
@pdabelf5 pdabelf5 added skip changelog Pull requests that don't need to be added to the changelog and removed documentation Pull requests/issues for documentation needs cherry pick Cherry pick this PR into a release branch labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changelog Pull requests that don't need to be added to the changelog
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants