Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated log level parameters #6620

Merged
merged 10 commits into from
Oct 9, 2024
Merged

Conversation

AlexFenlon
Copy link
Contributor

@AlexFenlon AlexFenlon commented Oct 8, 2024

Proposed changes

  • fix nil pointer when glog is removed in flags.go to prepare for full glog removal in the healthcheck package soon by removing a check forlogtostderr and include_year flags as logtostderr was included with glog and include_year has been removed.
  • update old -v= to -log-level= as it was only used for glog which has now been switched out and -v= has no longer been used since Add LogLevel & LogFormat flags #6520

What logtostderr flag was doing in glog

logtostderr (bool, default=false)
Log messages to stderr instead of logfiles.

Helm-chart will need to be updated to v2.0.0 as we have a breaking change changing from -v to -log-level so this needs to be done

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon requested a review from a team as a code owner October 8, 2024 15:42
@github-actions github-actions bot added go Pull requests that update Go code python Pull requests that update Python code tests Pull requests that update tests labels Oct 8, 2024
@AlexFenlon AlexFenlon self-assigned this Oct 8, 2024
@AlexFenlon AlexFenlon mentioned this pull request Oct 8, 2024
16 tasks
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.26%. Comparing base (297aa1b) to head (f6ec21b).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6620      +/-   ##
==========================================
+ Coverage   53.24%   53.26%   +0.01%     
==========================================
  Files          87       87              
  Lines       16263    16257       -6     
==========================================
  Hits         8660     8660              
+ Misses       7188     7182       -6     
  Partials      415      415              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@AlexFenlon AlexFenlon requested a review from a team as a code owner October 9, 2024 09:08
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/6620/

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though the PR is largely not docs-based.

@j1m-ryan
Copy link

j1m-ryan commented Oct 9, 2024

can you update the docs here https://github.com/nginxinc/kubernetes-ingress/blob/main/site/content/logging-and-monitoring/logging.md?

@AlexFenlon AlexFenlon enabled auto-merge (squash) October 9, 2024 13:00
@AlexFenlon AlexFenlon merged commit e7e1757 into main Oct 9, 2024
32 checks passed
@AlexFenlon AlexFenlon deleted the chore/clean-up-glog-leftovers branch October 9, 2024 13:03
@pdabelf5 pdabelf5 removed the documentation Pull requests/issues for documentation label Dec 13, 2024
@pdabelf5 pdabelf5 added chore Pull requests for routine tasks and removed go Pull requests that update Go code python Pull requests that update Python code tests Pull requests that update tests labels Dec 13, 2024
@pdabelf5 pdabelf5 changed the title refactor: fix nil pointer when glog is removed & update old -v= to -log-level= Remove deprecated log level parameters Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants