-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated log level parameters #6620
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6620 +/- ##
==========================================
+ Coverage 53.24% 53.26% +0.01%
==========================================
Files 87 87
Lines 16263 16257 -6
==========================================
Hits 8660 8660
+ Misses 7188 7182 -6
Partials 415 415 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
✅ Deploy Preview will be available once build job completes!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though the PR is largely not docs-based.
can you update the docs here https://github.com/nginxinc/kubernetes-ingress/blob/main/site/content/logging-and-monitoring/logging.md? |
Co-authored-by: Jim Ryan <[email protected]> Signed-off-by: AlexFenlon <[email protected]>
-v=
to -log-level=
Proposed changes
healthcheck
package soon by removing a check forlogtostderr
andinclude_year
flags aslogtostderr
was included with glog andinclude_year
has been removed.-v=
to-log-level=
as it was only used for glog which has now been switched out and-v=
has no longer been used since Add LogLevel & LogFormat flags #6520What logtostderr flag was doing in glog
Helm-chart will need to be updated to v2.0.0 as we have a breaking change changing from
-v
to-log-level
so this needs to be doneChecklist
Before creating a PR, run through this checklist and mark each as complete.