-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TransportServer SNI #6605
TransportServer SNI #6605
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6605 +/- ##
==========================================
+ Coverage 53.24% 53.44% +0.19%
==========================================
Files 87 87
Lines 20063 20111 +48
==========================================
+ Hits 10683 10748 +65
+ Misses 8950 8928 -22
- Partials 430 435 +5 ☔ View full report in Codecov by Sentry. |
✅ Deploy Preview will be available once build job completes!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I have a lot of edit suggestions.
Ordered list enumeration (1. repeated) is only available when writing a Hugo page.
It's very basic, but since explicit instructions are given for everything else, the example could also give the command to view the logs.
I may convert this to a proper documentation page at a later point: see #6572 for an example.
Co-authored-by: Alan Dooley <[email protected]> Signed-off-by: Jim Ryan <[email protected]>
examples/custom-resources/transport-server-sni/tcp-echo-server.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Jim Ryan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Proposed changes
TransportServer SNI
#6324
Checklist
Before creating a PR, run through this checklist and mark each as complete.