Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix go toolchain #6549

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Fix go toolchain #6549

merged 1 commit into from
Oct 1, 2024

Conversation

nginx-bot
Copy link
Contributor

Proposed changes

  • Move NIM instructions to WAF v5 section,
  • Fix go toolchain error with hugo commands

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@nginx-bot nginx-bot requested review from a team as code owners October 1, 2024 10:25
@nginx-bot nginx-bot added documentation Pull requests/issues for documentation needs cherry pick Cherry pick this PR into a release branch labels Oct 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/6549/

@vepatel vepatel removed the needs cherry pick Cherry pick this PR into a release branch label Oct 1, 2024
@vepatel vepatel changed the title [cherry-pick] move docs and fix go toolchain move docs and fix go toolchain Oct 1, 2024
@vepatel vepatel merged commit 7f1bf52 into release-3.7 Oct 1, 2024
24 checks passed
@vepatel vepatel deleted the cherry-pick-release-3.7-db1022dc6366dda30d1aa6b041b27076cfc43269 branch October 1, 2024 10:41
@pdabelf5 pdabelf5 added dependencies Pull requests that update a dependency file and removed documentation Pull requests/issues for documentation labels Nov 6, 2024
@pdabelf5 pdabelf5 changed the title move docs and fix go toolchain Fix go toolchain Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@vepatel vepatel vepatel approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nginx-bot @vepatel @AlexFenlon @pdabelf5