Add websockets support for vs/vsr upstreams #653
Merged
+56
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dean-Coakley
added
the
enhancement
Dean-Coakley
requested review from
pleshakov,
Rulox,
bvighnesha,
LorcanMcVeigh and
ampant
pleshakov
suggested changes
Aug 9, 2019
Dean-Coakley
force-pushed
the
add-websockets-vs-vsr
branch
from
aba3c2d to
163247e
Compare
pleshakov
suggested changes
Aug 12, 2019
There was a problem hiding this comment.
@Dean-Coakley thx for the update. Please revert the changes done for the Ingress resources, as those are not required for this PR.
Dean-Coakley
force-pushed
the
add-websockets-vs-vsr
branch
from
163247e to
853b57c
Compare
tellet
suggested changes
Aug 13, 2019
There was a problem hiding this comment.
@Dean-Coakley Could you please rebase onto master. There is a new test merged TestVSHealthCheckUpstreamOption. It should probably be updated too.
tellet
approved these changes
Aug 13, 2019
Dean-Coakley
force-pushed
the
add-websockets-vs-vsr
branch
from
7171c7f to
8783934
Compare
pleshakov
approved these changes
Aug 14, 2019
* Was testing for the presence of "proxy_set_header Connection" * Now tests for the presence of "set $default_connection_header" $default_connection_header is a custom variable that is used for upgrading to the Websocket protocol when using vs/vsr upstreams
Dean-Coakley
force-pushed
the
add-websockets-vs-vsr
branch
from
9949e2e to
2f61526
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds support for Websocket connections for upstreams without any additional configuration when configuring via VirtualServer or VirtualServerRoute.
Checklist
Before creating a PR, run through this checklist and mark each as complete.