Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix external url links #6519

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Fix external url links #6519

merged 1 commit into from
Sep 26, 2024

Conversation

nginx-aoife
Copy link
Contributor

@nginx-aoife nginx-aoife commented Sep 26, 2024 •
edited
Loading

Proposed changes

PR to fix 3 links to external sites that are returning 404s

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@nginx-aoife nginx-aoife requested review from a team as code owners September 26, 2024 13:51
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Sep 26, 2024
@nginx-aoife
Copy link
Contributor Author

@vepatel @j1m-ryan can one of ye merge it too please? I don't have the permissions. TiA.

@j1m-ryan j1m-ryan merged commit d41b90e into nginx:main Sep 26, 2024
30 checks passed
pdabelf5 pushed a commit that referenced this pull request Nov 7, 2024
@nginx-aoife @pdabelf5
Docs: fix external url links (#6519)
1249835 
Docs: fix external links
@pdabelf5 pdabelf5 changed the title Docs: fix external url links Fix external url links Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nginx-aoife @j1m-ryan @vepatel