Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hugo version check and theme update to Makefile #6518

Merged
merged 5 commits into from
Sep 26, 2024
Merged

Add hugo version check and theme update to Makefile #6518

merged 5 commits into from
Sep 26, 2024

Conversation

nginx-jack
Copy link
Contributor

@nginx-jack nginx-jack commented Sep 26, 2024 •
edited
Loading

Proposed changes

This should help prevent any hugo or hugo-theme version drift going forward, and warn when versions are out of date.

  • Add hugo version check and theme update to Makefile
  • Update README.md with correct make target behaviors
  • Add hugo-entrypoint to allow extra commands when docker starts
  • Update hugo theme version in go.mod
  • Use slimmer hugo docker image

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@nginx-jack
Add hugo version check and theme update to Makefile
3288c8e 
Update README.md with correct make target behaviors
Add hugo-entrypoint to allow extra commands when docker starts
Update hugo theme version in go.mod
Use slimmer hugo docker image
@nginx-jack nginx-jack requested review from a team as code owners September 26, 2024 10:38
vepatel
vepatel reviewed Sep 26, 2024
View reviewed changes
docs/go.mod Outdated Show resolved Hide resolved
j1m-ryan
j1m-ryan reviewed Sep 26, 2024
View reviewed changes
docs/go.sum Outdated Show resolved Hide resolved
@ADubhlaoich ADubhlaoich merged commit 3d3284f into nginx:main Sep 26, 2024
31 checks passed
nginx-jack added a commit to nginx-jack/kubernetes-ingress that referenced this pull request Oct 7, 2024
@nginx-jack
Add hugo version check and theme update to Makefile (nginx#6518)
d020646 
Update README.md with correct make target behaviors
Add hugo-entrypoint to allow extra commands when docker starts
Update hugo theme version in go.mod
Use slimmer hugo docker image
Fix docs-ci, bump go version

Co-authored-by: Jim Ryan <[email protected]>
@pdabelf5 pdabelf5 added the documentation Pull requests/issues for documentation label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel left review comments

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nginx-jack @ADubhlaoich @j1m-ryan @vepatel @pdabelf5