-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to prepare for structured logs #6501
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6501 +/- ##
==========================================
- Coverage 53.25% 53.20% -0.05%
==========================================
Files 85 85
Lines 16016 16018 +2
==========================================
- Hits 8529 8523 -6
- Misses 7081 7087 +6
- Partials 406 408 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
…agsgo-refactor-for-struct-logs
…t-logs' into chore/flagsgo-refactor-for-struct-logs
Proposed changes
refactor flags.go parseFlags to prepare for struct logs.
We are looking to split the flag parsing from the validation as we want to pass the logger to the validation function.
Checklist
Before creating a PR, run through this checklist and mark each as complete.