Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to prepare for structured logs #6501

Merged
merged 8 commits into from
Sep 26, 2024

Conversation

AlexFenlon
Copy link
Contributor

@AlexFenlon AlexFenlon commented Sep 25, 2024

Proposed changes

refactor flags.go parseFlags to prepare for struct logs.

We are looking to split the flag parsing from the validation as we want to pass the logger to the validation function.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon requested a review from a team as a code owner September 25, 2024 10:04
@github-actions github-actions bot added the go Pull requests that update Go code label Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.

Project coverage is 53.20%. Comparing base (f6afacb) to head (2d594ca).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
cmd/nginx-ingress/flags.go 0.00% 31 Missing ⚠️
cmd/nginx-ingress/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6501      +/-   ##
==========================================
- Coverage   53.25%   53.20%   -0.05%     
==========================================
  Files          85       85              
  Lines       16016    16018       +2     
==========================================
- Hits         8529     8523       -6     
- Misses       7081     7087       +6     
- Partials      406      408       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@AlexFenlon AlexFenlon enabled auto-merge (squash) September 26, 2024 07:49
@AlexFenlon AlexFenlon merged commit 4ee3676 into main Sep 26, 2024
79 checks passed
@AlexFenlon AlexFenlon deleted the chore/flagsgo-refactor-for-struct-logs branch September 26, 2024 08:26
@shaun-nx shaun-nx added this to the v3.7.0 milestone Sep 26, 2024
@AlexFenlon AlexFenlon self-assigned this Sep 26, 2024
@pdabelf5 pdabelf5 changed the title refactor to prepare for struct logs Refactor to prepare for structured logs Dec 16, 2024
@pdabelf5 pdabelf5 added chore Pull requests for routine tasks and removed go Pull requests that update Go code labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

5 participants