Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add marker to conftest #6491

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Add marker to conftest #6491

merged 1 commit into from
Sep 24, 2024

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Sep 24, 2024

Proposed changes

  • skip wafv5 test based on the image name

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner September 24, 2024 12:20
@github-actions github-actions bot added python Pull requests that update Python code tests Pull requests that update tests labels Sep 24, 2024
@vepatel vepatel enabled auto-merge (squash) September 24, 2024 13:31
@vepatel vepatel merged commit 217504b into main Sep 24, 2024
79 checks passed
@vepatel vepatel deleted the tests/fix-regression-job branch September 24, 2024 13:43
@pdabelf5 pdabelf5 removed python Pull requests that update Python code tests Pull requests that update tests labels Dec 13, 2024
@pdabelf5 pdabelf5 changed the title add marker to conftest Add marker to conftest Dec 16, 2024
@pdabelf5 pdabelf5 added the tests Pull requests that update tests label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdabelf5 pdabelf5 pdabelf5 approved these changes

@jjngx jjngx jjngx approved these changes

Assignees
No one assigned
Labels
tests Pull requests that update tests
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vepatel @jjngx @pdabelf5