-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add glog slog handler #6474
Merged
Merged
Add glog slog handler #6474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6474 +/- ##
==========================================
+ Coverage 53.21% 53.30% +0.09%
==========================================
Files 85 87 +2
Lines 16016 16074 +58
==========================================
+ Hits 8523 8569 +46
- Misses 7085 7097 +12
Partials 408 408 ☔ View full report in Codecov by Sentry. |
it looks great! 🚀 |
pdabelf5
force-pushed
the
slog-handler
branch
from
September 25, 2024 09:24
a141085
to
c869291
Compare
pdabelf5
force-pushed
the
slog-handler
branch
from
September 25, 2024 09:25
c869291
to
1c0ae9e
Compare
AlexFenlon
approved these changes
Sep 25, 2024
jjngx
approved these changes
Sep 25, 2024
pdabelf5
added
enhancement
Pull requests for new features/feature enhancements
and removed
go
Pull requests that update Go code
labels
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
glog
formattingTo create a new
slog
based logger using theglog
handler you can use code similar to:To attach the logger to a context you can use:
To retrieve the logger from the context use
slog
does not provideFatal
&Trace
log levels by default. These have been added to theglog
handler but the following syntax is needed to log using these levelsNote: The
l.Log(context.Background(), LevelFatal, "test")
implementation needs to callos.Exit()
as the Fatal level does not exit itself.Checklist
Before creating a PR, run through this checklist and mark each as complete.