Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix udp/http listener validation logic #6406

Merged
merged 17 commits into from
Sep 17, 2024

Conversation

j1m-ryan
Copy link
Contributor

@j1m-ryan j1m-ryan commented Sep 12, 2024

Proposed changes

Fixes #6408

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@j1m-ryan j1m-ryan requested a review from a team as a code owner September 12, 2024 14:47
@github-actions github-actions bot added bug An issue reporting a potential bug go Pull requests that update Go code labels Sep 12, 2024
@github-actions github-actions bot added the helm_chart Pull requests that update the Helm Chart label Sep 12, 2024
@github-actions github-actions bot removed the helm_chart Pull requests that update the Helm Chart label Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 53.21%. Comparing base (166b954) to head (d91e730).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...is/configuration/validation/globalconfiguration.go 85.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6406   +/-   ##
=======================================
  Coverage   53.20%   53.21%           
=======================================
  Files          85       85           
  Lines       16002    16009    +7     
=======================================
+ Hits         8514     8519    +5     
- Misses       7081     7082    +1     
- Partials      407      408    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added python Pull requests that update Python code tests Pull requests that update tests labels Sep 12, 2024
@j1m-ryan j1m-ryan enabled auto-merge (squash) September 17, 2024 11:00
@j1m-ryan j1m-ryan merged commit 5e96dd2 into main Sep 17, 2024
80 checks passed
@j1m-ryan j1m-ryan deleted the fix/udp-http-listener-validation-logic branch September 17, 2024 11:33
@pdabelf5 pdabelf5 changed the title fix udp/http listener validation logic Fix udp/http listener validation logic Sep 23, 2024
@pdabelf5 pdabelf5 removed go Pull requests that update Go code python Pull requests that update Python code tests Pull requests that update tests labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

[Bug]: UDP listener should be able to share a IP Port combo with a TCP/HTTP Listener
4 participants