-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix udp/http listener validation logic #6406
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
An issue reporting a potential bug
go
Pull requests that update Go code
labels
Sep 12, 2024
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
github-actions
bot
removed
the
helm_chart
Pull requests that update the Helm Chart
label
Sep 12, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6406 +/- ##
=======================================
Coverage 53.20% 53.21%
=======================================
Files 85 85
Lines 16002 16009 +7
=======================================
+ Hits 8514 8519 +5
- Misses 7081 7082 +1
- Partials 407 408 +1 ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
python
Pull requests that update Python code
tests
Pull requests that update tests
labels
Sep 12, 2024
jjngx
approved these changes
Sep 13, 2024
vepatel
approved these changes
Sep 16, 2024
pdabelf5
changed the title
fix udp/http listener validation logic
Fix udp/http listener validation logic
Sep 23, 2024
pdabelf5
removed
go
Pull requests that update Go code
python
Pull requests that update Python code
tests
Pull requests that update tests
labels
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #6408
Checklist
Before creating a PR, run through this checklist and mark each as complete.