Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HealthChecks support for vs/vsr #635

Merged
merged 1 commit into from
Aug 6, 2019
Merged

Add HealthChecks support for vs/vsr #635

merged 1 commit into from
Aug 6, 2019

Conversation

Rulox
Copy link
Contributor

@Rulox Rulox commented Jul 24, 2019

Proposed changes

Add HealthCheck features for VS and VSR (NGINX Plus only).

@Rulox Rulox self-assigned this Jul 24, 2019
pleshakov
pleshakov suggested changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rulox looks good. Some small doc fixes + some validation rules improvements

docs/virtualserver-and-virtualserverroute.md Outdated Show resolved Hide resolved
docs/virtualserver-and-virtualserverroute.md Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation.go Outdated Show resolved Hide resolved
internal/configs/version2/nginx-plus.virtualserver.tmpl Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation.go Outdated Show resolved Hide resolved
@pleshakov pleshakov mentioned this pull request Jul 25, 2019
Closed
@Rulox Rulox requested a review from pleshakov July 26, 2019 14:28
@Rulox
Copy link
Contributor Author

Rulox commented Jul 26, 2019

Ready to review

@Rulox Rulox force-pushed the upstream-healthchecks branch from 44c50e8 to adf7017 Compare July 29, 2019 11:19
pleshakov
pleshakov suggested changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few validation cases left to be covered.

pkg/apis/configuration/validation/validation.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation_test.go Outdated Show resolved Hide resolved
@Rulox Rulox requested a review from pleshakov July 31, 2019 11:55
pleshakov
pleshakov suggested changes Aug 1, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few small problems.

pkg/apis/configuration/validation/validation.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation.go Outdated Show resolved Hide resolved
pkg/apis/configuration/validation/validation.go Outdated Show resolved Hide resolved
pleshakov
pleshakov approved these changes Aug 2, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Rulox Rulox force-pushed the upstream-healthchecks branch from 0c3c469 to 8f32a76 Compare August 6, 2019 08:41
@Rulox Rulox merged commit 58faa98 into master Aug 6, 2019
@Rulox Rulox deleted the upstream-healthchecks branch August 6, 2019 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LorcanMcVeigh LorcanMcVeigh LorcanMcVeigh approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@pleshakov pleshakov pleshakov approved these changes

Assignees

@Rulox Rulox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rulox @pleshakov @Dean-Coakley @LorcanMcVeigh