Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Active Connections support to vs/vsr #634

Merged
merged 2 commits into from
Jul 26, 2019
Merged

Add Active Connections support to vs/vsr #634

merged 2 commits into from
Jul 26, 2019

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

Add support to be able to configure max-conns for an upstream in my VirtualServer/VirtualServerRoute.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley added the enhancement Pull requests for new features/feature enhancements label Jul 24, 2019
@Dean-Coakley Dean-Coakley self-assigned this Jul 24, 2019
@Dean-Coakley Dean-Coakley force-pushed the feature/max-conns-vs-vsr branch 2 times, most recently from 355e9a3 to 286341f Compare July 24, 2019 20:52
Rulox
Rulox suggested changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@Rulox Rulox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀 Just a small question

pkg/apis/configuration/v1alpha1/types.go Outdated Show resolved Hide resolved
LorcanMcVeigh
LorcanMcVeigh approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@LorcanMcVeigh LorcanMcVeigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

pleshakov
pleshakov approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Dean-Coakley Dean-Coakley force-pushed the feature/max-conns-vs-vsr branch 2 times, most recently from ef245eb to 48128db Compare July 26, 2019 16:32
@Dean-Coakley Dean-Coakley force-pushed the feature/max-conns-vs-vsr branch from 48128db to 871eb4e Compare July 26, 2019 16:37
@Dean-Coakley Dean-Coakley merged commit e2337bb into master Jul 26, 2019
@Dean-Coakley Dean-Coakley deleted the feature/max-conns-vs-vsr branch July 26, 2019 19:49
@Dean-Coakley Dean-Coakley mentioned this pull request Jul 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LorcanMcVeigh LorcanMcVeigh LorcanMcVeigh approved these changes

@Rulox Rulox Rulox approved these changes

@pleshakov pleshakov pleshakov approved these changes

Assignees

@Dean-Coakley Dean-Coakley

Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dean-Coakley @pleshakov @Rulox @LorcanMcVeigh