Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move fips note to top of release notes #6252

Merged
merged 2 commits into from
Aug 20, 2024
Merged

move fips note to top of release notes #6252

merged 2 commits into from
Aug 20, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Aug 20, 2024 •
edited
Loading

Proposed changes

Make sure the notice about the FIPS images is at the top of the release notes.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested review from a team as code owners August 20, 2024 12:49
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Aug 20, 2024
@pdabelf5 pdabelf5 added the needs cherry pick Cherry pick this PR into a release branch label Aug 20, 2024
@github-actions GitHub Actions
Copy link

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/6252/

@pdabelf5 pdabelf5 enabled auto-merge (squash) August 20, 2024 13:11
@pdabelf5 pdabelf5 merged commit 65f1782 into main Aug 20, 2024
48 checks passed
@pdabelf5 pdabelf5 deleted the fips-note-docs branch August 20, 2024 13:14
pdabelf5 added a commit that referenced this pull request Aug 20, 2024
@pdabelf5
move fips note to top of release notes (#6252)
535d412
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation needs cherry pick Cherry pick this PR into a release branch
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pdabelf5 @j1m-ryan @vepatel