Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix staticcheck linter complains #6159

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Fix staticcheck linter complains #6159

merged 3 commits into from
Aug 8, 2024

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Aug 8, 2024

Proposed changes

This PR fixes staticcheck complains about Go error messages:

➜  kubernetes-ingress git:(fix/staticcheck-go-errors) ✗ staticcheck internal/k8s/appprotect/*.go
internal/k8s/appprotect/app_protect_configuration.go:293:74: error strings should not be capitalized (ST1005)
internal/k8s/appprotect/app_protect_configuration.go:402:15: error strings should not be capitalized (ST1005)
internal/k8s/appprotect/app_protect_configuration.go:410:15: error strings should not be capitalized (ST1005)
internal/k8s/appprotect/app_protect_configuration.go:418:15: error strings should not be capitalized (ST1005)
internal/k8s/appprotect/app_protect_configuration.go:420:14: error strings should not be capitalized (ST1005)
internal/k8s/appprotect/app_protect_configuration.go:602:15: error strings should not be capitalized (ST1005)
internal/k8s/appprotect/app_protect_configuration.go:607:15: error strings should not be capitalized (ST1005)
internal/k8s/appprotect/app_protect_configuration.go:609:14: error strings should not be capitalized (ST1005)

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner August 8, 2024 09:08
@github-actions github-actions bot added bug An issue reporting a potential bug go Pull requests that update Go code labels Aug 8, 2024
@jjngx jjngx removed the bug An issue reporting a potential bug label Aug 8, 2024
@github-actions github-actions bot added the bug An issue reporting a potential bug label Aug 8, 2024
@jjngx jjngx removed the bug An issue reporting a potential bug label Aug 8, 2024
@jjngx jjngx self-assigned this Aug 8, 2024
@jjngx jjngx merged commit 06e19e2 into main Aug 8, 2024
77 checks passed
@jjngx jjngx deleted the fix/staticcheck-go-errors branch August 8, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants