Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit-tests to regression pipeline #6152

Merged
merged 9 commits into from
Aug 14, 2024
Merged

add unit-tests to regression pipeline #6152

merged 9 commits into from
Aug 14, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Aug 7, 2024

Proposed changes

  • add unit tests to regression pipeline to ensure report is uploaded to codecov.io
  • refactor unit-test/coverage make targets

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added chore Pull requests for routine tasks go Pull requests that update Go code github_actions Pull requests that update Github_actions code labels Aug 7, 2024
@github-actions github-actions bot removed the github_actions Pull requests that update Github_actions code label Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.24%. Comparing base (8a2c9a9) to head (b5bb1dd).
Report is 565 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6152      +/-   ##
==========================================
- Coverage   52.32%   43.24%   -9.08%     
==========================================
  Files          61      142      +81     
  Lines       17502    19970    +2468     
==========================================
- Hits         9158     8637     -521     
- Misses       8015    10884    +2869     
- Partials      329      449     +120     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added github_actions Pull requests that update Github_actions code and removed go Pull requests that update Go code labels Aug 14, 2024
@pdabelf5 pdabelf5 changed the title add logging to codecov report generation add unit-tests to regression pipeline Aug 14, 2024
@pdabelf5 pdabelf5 marked this pull request as ready for review August 14, 2024 11:11
@pdabelf5 pdabelf5 requested a review from a team as a code owner August 14, 2024 11:11
@pdabelf5 pdabelf5 merged commit 746803b into main Aug 14, 2024
77 checks passed
@pdabelf5 pdabelf5 deleted the codecov branch August 14, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks github_actions Pull requests that update Github_actions code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants