Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

be explicit where images are tagged #6104

Merged
merged 2 commits into from
Jul 31, 2024
Merged

be explicit where images are tagged #6104

merged 2 commits into from
Jul 31, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Jul 30, 2024

Proposed changes

Remove additional image tagging from copy-images.sh and make it clear the tags are added in the workflows. This removes confusion about where images are tagged.

Add date tag when publishing initial release, inline with image patching flow.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner July 30, 2024 15:52
@github-actions github-actions bot added github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels Jul 30, 2024
@pdabelf5 pdabelf5 merged commit 5de4c80 into main Jul 31, 2024
76 checks passed
@pdabelf5 pdabelf5 deleted the update-version-date branch July 31, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks github_actions Pull requests that update Github_actions code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants