Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix govluncheck sarif upload #6086

Merged
merged 4 commits into from
Jul 29, 2024
Merged

Conversation

j1m-ryan
Copy link

@j1m-ryan j1m-ryan commented Jul 29, 2024

Proposed changes

Fix sarif file upload for govulncheck in image promotion workflow
if there is no results array, eg govulncheck did not find any problems, dont upload the sarif file

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels Jul 29, 2024
@j1m-ryan j1m-ryan marked this pull request as ready for review July 29, 2024 13:45
@j1m-ryan j1m-ryan requested a review from a team as a code owner July 29, 2024 13:45
@j1m-ryan j1m-ryan merged commit fc0904a into main Jul 29, 2024
76 checks passed
@j1m-ryan j1m-ryan deleted the chore/only-upload-sarif-if-has-results branch July 29, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks github_actions Pull requests that update Github_actions code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants