Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortcode for NIC version in docs #5975

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Shortcode for NIC version in docs #5975

merged 1 commit into from
Jul 5, 2024

Conversation

nginx-bot
Copy link
Contributor

Proposed changes

Move version numbers to Hugo shortcodes to avoid large repeated PRs every release.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@nginx-bot nginx-bot requested a review from a team as a code owner July 5, 2024 14:38
@nginx-bot nginx-bot added the chore Pull requests for routine tasks label Jul 5, 2024
@nginx-bot nginx-bot requested a review from a team as a code owner July 5, 2024 14:38
@nginx-bot nginx-bot added dependencies Pull requests that update a dependency file documentation Pull requests/issues for documentation github_actions Pull requests that update Github_actions code needs cherry pick Cherry pick this PR into a release branch labels Jul 5, 2024
@github-actions github-actions bot added python Pull requests that update Python code tests Pull requests that update tests and removed dependencies Pull requests that update a dependency file labels Jul 5, 2024
@pdabelf5 pdabelf5 force-pushed the cherry-pick-release-3.6-6f8709f00774ab0b173c017e9265a9b9cf6d4ef1 branch from 17d811d to 0340097 Compare July 5, 2024 14:45
@github-actions github-actions bot removed python Pull requests that update Python code tests Pull requests that update tests labels Jul 5, 2024
@oseoin oseoin enabled auto-merge (squash) July 5, 2024 14:46
@pdabelf5 pdabelf5 removed the needs cherry pick Cherry pick this PR into a release branch label Jul 5, 2024
@oseoin oseoin merged commit 92352e4 into release-3.6 Jul 5, 2024
65 checks passed
@oseoin oseoin deleted the cherry-pick-release-3.6-6f8709f00774ab0b173c017e9265a9b9cf6d4ef1 branch July 5, 2024 15:15
@pdabelf5 pdabelf5 changed the title [cherry-pick] Shortcode for NIC version in docs Shortcode for NIC version in docs Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdabelf5 pdabelf5 pdabelf5 approved these changes

@jjngx jjngx jjngx approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@oseoin oseoin oseoin approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks documentation Pull requests/issues for documentation github_actions Pull requests that update Github_actions code
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nginx-bot @oseoin @j1m-ryan @AlexFenlon @jjngx @pdabelf5