Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove enable preview policies flag from docs #5891

Merged
merged 5 commits into from
Jul 2, 2024

Conversation

j1m-ryan
Copy link

@j1m-ryan j1m-ryan commented Jun 28, 2024

Proposed changes

#5777

Only reference to this policy is in the docs. It does not do anything as it was fully deprecated prior to this.

@j1m-ryan j1m-ryan requested review from a team as code owners June 28, 2024 16:20
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jun 28, 2024
@j1m-ryan j1m-ryan added the needs cherry pick Cherry pick this PR into a release branch label Jul 1, 2024
@haywoodsh
Copy link
Contributor

I just did a quick search in the codebase and there is one more place referencing the preview flag https://github.com/nginxinc/kubernetes-ingress/blob/main/pkg/apis/configuration/v1/types.go#L623

@github-actions github-actions bot added the go Pull requests that update Go code label Jul 1, 2024
@j1m-ryan j1m-ryan enabled auto-merge (squash) July 1, 2024 13:26
@j1m-ryan j1m-ryan removed the needs cherry pick Cherry pick this PR into a release branch label Jul 1, 2024
@j1m-ryan j1m-ryan disabled auto-merge July 2, 2024 10:25
@j1m-ryan j1m-ryan merged commit 4ab76e7 into main Jul 2, 2024
80 checks passed
@j1m-ryan j1m-ryan deleted the chore/remove-deprecated-enable-preview-policies-docs branch July 2, 2024 10:40
@vepatel vepatel linked an issue Jul 2, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation go Pull requests that update Go code
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Remove enable-preview-policies flag documentation
4 participants