Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split VSR matrix in 3 #5883

Merged
merged 4 commits into from
Jun 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions .github/data/matrix-smoke-oss.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,24 @@
"platforms": "linux/arm, linux/arm64, linux/amd64, linux/ppc64le, linux/s390x"
},
{
"label": "VSR",
"label": "VSR 1/3",
"image": "alpine",
"type": "oss",
"marker": "vsr",
"marker": "'vsr and not vsr_upstream and not vsr_grpc and not vsr_status and not vsr_canary and not vsr_routing and not vsr_api and not vsr_redirects and not vsr_rewrite and not vsr_canned and not vsr_basic'",
"platforms": "linux/arm, linux/arm64, linux/amd64, linux/ppc64le, linux/s390x"
},
{
"label": "VSR 2/3",
"image": "alpine",
"type": "oss",
"marker": "'vsr_basic or vsr_canned or vsr_rewrite or vsr_redirects or vsr_upstream'",
"platforms": "linux/arm, linux/arm64, linux/amd64, linux/ppc64le, linux/s390x"
},
{
"label": "VSR 3/3",
"image": "alpine",
"type": "oss",
"marker": "'vsr_api or vsr_routing or vsr_canary or vsr_status or vsr_grpc'",
"platforms": "linux/arm, linux/arm64, linux/amd64, linux/ppc64le, linux/s390x"
},
{
Expand Down
18 changes: 16 additions & 2 deletions .github/data/matrix-smoke-plus.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,24 @@
"platforms": "linux/arm64, linux/amd64"
},
{
"label": "VSR",
"label": "VSR 1/3",
"image": "alpine-plus",
"type": "plus",
"marker": "vsr",
"marker": "'vsr and not vsr_upstream and not vsr_grpc and not vsr_status and not vsr_canary and not vsr_routing and not vsr_api and not vsr_redirects and not vsr_rewrite and not vsr_canned and not vsr_basic'",
"platforms": "linux/arm64, linux/amd64"
},
{
"label": "VSR 2/3",
"image": "alpine-plus",
"type": "plus",
"marker": "'vsr_basic or vsr_canned or vsr_rewrite or vsr_redirects or vsr_upstream'",
"platforms": "linux/arm64, linux/amd64"
},
{
"label": "VSR 3/3",
"image": "alpine-plus",
"type": "plus",
"marker": "'vsr_api or vsr_routing or vsr_canary or vsr_status or vsr_grpc'",
"platforms": "linux/arm64, linux/amd64"
},
{
Expand Down
1 change: 1 addition & 0 deletions tests/suite/test_rewrites.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ def test_vs_rewrite(self, vs_rewrites_setup, path, args, cookies, expected):
assert f"URI: {expected}\nRequest" in resp.text

@pytest.mark.vsr
@pytest.mark.vsr_rewrite
@pytest.mark.parametrize("path,args,cookies,expected", test_data)
def test_vsr_rewrite(self, vsr_rewrites_setup, path, args, cookies, expected):
"""
Expand Down
3 changes: 3 additions & 0 deletions tests/suite/test_v_s_route.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ def assert_locations_not_in_config(config, paths):

@pytest.mark.smoke
@pytest.mark.vsr
@pytest.mark.vsr_basic
@pytest.mark.parametrize(
"crd_ingress_controller, v_s_route_setup",
[({"type": "complete", "extra_args": [f"-enable-custom-resources"]}, {"example": "virtual-server-route"})],
Expand Down Expand Up @@ -267,6 +268,7 @@ def test_responses_and_events_in_flow(


@pytest.mark.vsr
@pytest.mark.vsr_basic
@pytest.mark.parametrize(
"crd_ingress_controller, v_s_route_setup",
[({"type": "complete", "extra_args": [f"-enable-custom-resources"]}, {"example": "virtual-server-route"})],
Expand Down Expand Up @@ -369,6 +371,7 @@ def test_openapi_validation_flow(


@pytest.mark.vsr
@pytest.mark.vsr_basic
@pytest.mark.flaky(max_runs=3)
@pytest.mark.parametrize(
"crd_ingress_controller, v_s_route_setup",
Expand Down
1 change: 1 addition & 0 deletions tests/suite/test_v_s_route_advanced_routing.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ def fin():


@pytest.mark.vsr
@pytest.mark.vsr_routing
@pytest.mark.parametrize(
"crd_ingress_controller, vsr_adv_routing_setup",
[
Expand Down
1 change: 1 addition & 0 deletions tests/suite/test_v_s_route_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@


@pytest.mark.vsr
@pytest.mark.vsr_api
@pytest.mark.skip_for_nginx_oss
@pytest.mark.parametrize(
"crd_ingress_controller, v_s_route_setup",
Expand Down
1 change: 1 addition & 0 deletions tests/suite/test_v_s_route_canned_responses.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@


@pytest.mark.vsr
@pytest.mark.vsr_canned
@pytest.mark.parametrize(
"crd_ingress_controller, v_s_route_setup",
[
Expand Down
1 change: 1 addition & 0 deletions tests/suite/test_v_s_route_error_pages.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@


@pytest.mark.vsr
@pytest.mark.vsr_error_pages
@pytest.mark.parametrize(
"crd_ingress_controller, v_s_route_setup",
[
Expand Down
1 change: 1 addition & 0 deletions tests/suite/test_v_s_route_externalname.py
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ def fin():


@pytest.mark.vsr
@pytest.mark.vsr_external_name
@pytest.mark.skip_for_nginx_oss
@pytest.mark.parametrize(
"crd_ingress_controller, vsr_externalname_setup",
Expand Down
1 change: 1 addition & 0 deletions tests/suite/test_v_s_route_focused_canary.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ def fin():

@pytest.mark.flaky(max_runs=3)
@pytest.mark.vsr
@pytest.mark.vsr_canary
@pytest.mark.parametrize(
"crd_ingress_controller, vsr_canary_setup",
[
Expand Down
1 change: 1 addition & 0 deletions tests/suite/test_v_s_route_grpc.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ def fin():


@pytest.mark.vsr
@pytest.mark.vsr_grpc
@pytest.mark.smoke
@pytest.mark.parametrize(
"crd_ingress_controller, v_s_route_setup",
Expand Down
1 change: 1 addition & 0 deletions tests/suite/test_v_s_route_redirects.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@


@pytest.mark.vsr
@pytest.mark.vsr_redirects
@pytest.mark.parametrize(
"crd_ingress_controller, v_s_route_setup",
[
Expand Down
2 changes: 2 additions & 0 deletions tests/suite/test_v_s_route_regexp_location.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@


@pytest.mark.vsr
@pytest.mark.vsr_regexes
@pytest.mark.parametrize(
"crd_ingress_controller, v_s_route_setup",
[
Expand Down Expand Up @@ -214,6 +215,7 @@ def vsr_regexp_setup(


@pytest.mark.vsr
@pytest.mark.vsr_regexes
@pytest.mark.parametrize(
"crd_ingress_controller, vsr_regexp_setup",
[
Expand Down
1 change: 1 addition & 0 deletions tests/suite/test_v_s_route_split_traffic.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ def get_upstreams_of_splitting(file) -> []:


@pytest.mark.vsr
@pytest.mark.vsr_splits
@pytest.mark.parametrize(
"crd_ingress_controller, v_s_route_setup",
[
Expand Down
1 change: 1 addition & 0 deletions tests/suite/test_v_s_route_status.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@


@pytest.mark.vsr
@pytest.mark.vsr_status
@pytest.mark.parametrize(
"crd_ingress_controller, v_s_route_setup",
[
Expand Down
3 changes: 3 additions & 0 deletions tests/suite/test_v_s_route_upstream_options.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
indirect=True,
)
@pytest.mark.vsr
@pytest.mark.vsr_upstream
class TestVSRouteUpstreamOptions:
def test_nginx_config_upstreams_defaults(
self, kube_apis, ingress_controller_prerequisites, crd_ingress_controller, v_s_route_setup, v_s_route_app_setup
Expand Down Expand Up @@ -393,6 +394,7 @@ def test_v_s_r_overrides_config_map(


@pytest.mark.vsr
@pytest.mark.vsr_upstream
@pytest.mark.parametrize(
"crd_ingress_controller, v_s_route_setup",
[
Expand Down Expand Up @@ -544,6 +546,7 @@ def test_openapi_validation_flow(


@pytest.mark.vsr
@pytest.mark.vsr_upstream
@pytest.mark.skip_for_nginx_oss
@pytest.mark.parametrize(
"crd_ingress_controller, v_s_route_setup",
Expand Down
1 change: 1 addition & 0 deletions tests/suite/test_v_s_route_upstream_tls.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ def fin():


@pytest.mark.vsr
@pytest.mark.vsr_upstream
@pytest.mark.parametrize(
"crd_ingress_controller, v_s_route_setup",
[
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ def fin():


@pytest.mark.vsr
@pytest.mark.vsr_splits
@pytest.mark.smok
@pytest.mark.skip_for_nginx_oss
@pytest.mark.parametrize(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ def fin():


@pytest.mark.vsr
@pytest.mark.vsr_splits
@pytest.mark.smok
@pytest.mark.skip_for_nginx_oss
@pytest.mark.parametrize(
Expand Down
2 changes: 2 additions & 0 deletions tests/suite/test_watch_secret_namespace.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@


@pytest.mark.vsr
@pytest.mark.vsr_secrets
@pytest.mark.parametrize(
"crd_ingress_controller, v_s_route_setup",
[
Expand Down Expand Up @@ -62,6 +63,7 @@ def test_responses(


@pytest.mark.vsr
@pytest.mark.vsr_secrets
@pytest.mark.parametrize(
"crd_ingress_controller, v_s_route_setup",
[
Expand Down