Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure example versions are updated #5853

Merged
merged 2 commits into from
Jun 25, 2024
Merged

ensure example versions are updated #5853

merged 2 commits into from
Jun 25, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Jun 25, 2024 •
edited
Loading

Proposed changes

Ensure .md files in the version directory are updated with the new NIC/helm versions on release docs PR's

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner June 25, 2024 12:31
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jun 25, 2024
@oseoin oseoin enabled auto-merge (squash) June 25, 2024 12:37
@oseoin oseoin merged commit e7f4885 into main Jun 25, 2024
79 checks passed
@oseoin oseoin deleted the update-docs-pr-scripts branch June 25, 2024 13:26
pdabelf5 added a commit that referenced this pull request Jul 1, 2024
@pdabelf5
ensure example versions are updated (#5853)
fa98a1b
AlexFenlon pushed a commit that referenced this pull request Jul 1, 2024
@pdabelf5 @AlexFenlon
ensure example versions are updated (#5853)
4de40ae
@AlexFenlon AlexFenlon mentioned this pull request Jul 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaun-nx shaun-nx shaun-nx approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@vepatel vepatel vepatel approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@oseoin oseoin oseoin approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pdabelf5 @oseoin @j1m-ryan @vepatel @AlexFenlon @shaun-nx