Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name to image promotion and always run promotion #5793

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Add name to image promotion and always run promotion #5793

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fca1581
add name to image promotion and always run promotion
oseoin Jun 19, 2024
03726e9
fix cancelled logic
oseoin Jun 19, 2024
1f82aac
fix needs on tag-candidate
oseoin Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions .github/workflows/image-promotion.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
name: Image Promotion
# This workflow will:
# - build images for forked workflows
# - tag stable for forked workflows
Expand Down Expand Up @@ -299,9 +300,17 @@ jobs:
dry_run: false
secrets: inherit

tag-edge:
tag-candidate:
# pushes edge or release images to gcr/dev
# for main: this keeps a copy of edge in gcr/dev
# for release-*: this stages a release candidate in gcr/dev which can be used for release promotion
name: Tag tested image as stable
needs: [checks, build-docker, build-docker-plus, build-docker-nap]
needs:
- checks
- build-docker
- build-docker-plus
- build-docker-nap
- tag-stable
permissions:
contents: read # To checkout repository
id-token: write # To sign into Google Container Registry
Expand All @@ -311,9 +320,11 @@ jobs:
target_tag: ${{ github.ref_name == github.event.repository.default_branch && 'edge' || github.ref_name }}
dry_run: false
secrets: inherit
if: ${{ !cancelled() && !failure() }}

release-oss:
if: ${{ github.ref_name == github.event.repository.default_branch }}
# pushes edge images to docker hub
if: ${{ !cancelled() && !failure() && github.ref_name == github.event.repository.default_branch }}
name: Release Docker OSS
needs: [checks, build-docker]
uses: ./.github/workflows/oss-release.yml
Expand All @@ -333,7 +344,8 @@ jobs:
secrets: inherit

release-plus:
if: ${{ github.ref_name == github.event.repository.default_branch }}
# pushes plus edge images to nginx registry
if: ${{ !cancelled() && !failure() && github.ref_name == github.event.repository.default_branch }}
name: Release Docker Plus
needs: [checks, build-docker-plus, build-docker-nap]
uses: ./.github/workflows/plus-release.yml
Expand All @@ -352,7 +364,7 @@ jobs:
secrets: inherit

publish-helm-chart:
if: ${{ github.ref_name == github.event.repository.default_branch }}
if: ${{ !cancelled() && !failure() && github.ref_name == github.event.repository.default_branch }}
name: Publish Helm Chart
needs: [checks]
uses: ./.github/workflows/publish-helm.yml
Expand All @@ -367,7 +379,7 @@ jobs:
secrets: inherit

certify-openshift-images:
if: ${{ github.ref_name == github.event.repository.default_branch }}
if: ${{ !cancelled() && !failure() && github.ref_name == github.event.repository.default_branch }}
name: Certify OpenShift UBI images
runs-on: ubuntu-22.04
needs: [release-oss]
Expand Down
Loading