Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change log level, to Info and above, before calling prometheus exporter functions #5786

Merged
merged 9 commits into from
Jun 20, 2024
Merged

Change log level, to Info and above, before calling prometheus exporter functions #5786

merged 9 commits into from
Jun 20, 2024

Conversation

j1m-ryan
Copy link

@j1m-ryan j1m-ryan commented Jun 19, 2024 •
edited
Loading

Manual Tests

Fixes #5607
Add these logs to the collect function (temporarily) in my local NGINX Prometheus Exporter repo
image
Point my go.mod towards that local repo
Add the change that sets the log level to Info
Hit the :9113/metrics endpoint
Look at the logs
image
No sign of the debug log

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added bug An issue reporting a potential bug go Pull requests that update Go code labels Jun 19, 2024
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jun 19, 2024
@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label Jun 19, 2024
@j1m-ryan j1m-ryan changed the title wrap logger Change log level of logger, to Info and above, before calling prometheus exporter functions Jun 19, 2024
@j1m-ryan j1m-ryan changed the title Change log level of logger, to Info and above, before calling prometheus exporter functions Change log level, to Info and above, before calling prometheus exporter functions Jun 19, 2024
@j1m-ryan j1m-ryan marked this pull request as ready for review June 19, 2024 16:01
@j1m-ryan j1m-ryan requested a review from a team as a code owner June 19, 2024 16:01
@j1m-ryan j1m-ryan enabled auto-merge (squash) June 20, 2024 12:45
@pdabelf5 pdabelf5 added the needs cherry pick Cherry pick this PR into a release branch label Jun 20, 2024
@j1m-ryan j1m-ryan merged commit 9f7634f into main Jun 20, 2024
78 checks passed
@j1m-ryan j1m-ryan deleted the fix/wrap-logger branch June 20, 2024 16:04
nginx-bot pushed a commit that referenced this pull request Jun 20, 2024
@web-flow
Change log level, to Info and above, before calling prometheus export…
469c9c8 
…er functions (#5786)

* wrap logger

* tidy go mod

* remove level library import

* make library indirect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdabelf5 pdabelf5 pdabelf5 approved these changes

@jjngx jjngx jjngx approved these changes

Assignees
No one assigned
Labels
bug An issue reporting a potential bug go Pull requests that update Go code needs cherry pick Cherry pick this PR into a release branch
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
3 participants
@j1m-ryan @jjngx @pdabelf5