Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow refactor #5766

Merged
merged 48 commits into from
Jun 19, 2024
Merged

Workflow refactor #5766

merged 48 commits into from
Jun 19, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Jun 17, 2024 •
edited
Loading

Proposed changes

Refactor main pull request and post merge workflow to:

  • build docker images once per pipeline
  • re-use built images in tests
  • check to make sure images are not needlessly rebuilt, i.e. images content is based on md5sums of the codebase
  • tag images as stable once they pass the smoke tests
  • refactor edge generation workflow, now called image-promotion.yml
  • remove release workflow from pull request & edge workflows
  • add force build option to ci.yml to always rebuild images, not from the cache.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

pdabelf5 and others added 16 commits June 12, 2024 10:25
@pdabelf5
refactor main CI workflow
891858f
@pdabelf5
testing azure upload
5c1de47
@pdabelf5
added dry_run to azure upload
5415dcb
@pdabelf5
remove excess permissions
e400a46
@pdabelf5
add github release to release workflow
f35b132
@pdabelf5
notify if release pipeline fails
7c95c94
@pdabelf5
add slack notifications
c95231f
@pasmant @pdabelf5
Fix test_dos_sec_logs_on (#5725)
ea2d395
@vepatel @pdabelf5
enable external service args (#5736)
bd93b6b
@shaun-nx @pdabelf5
Integrate NAP WAF v5 (#5698)
f6717e1
@dependabot @pdabelf5
Bump github/codeql-action from 3.25.8 to 3.25.9 in the actions group (#…
580940a 
…5739)
@oseoin @pdabelf5
Mount config and deployments dirs to smoke containers (#5740)
bf146cd
@ADubhlaoich @vepatel @pdabelf5
Add F5 prefix to configuration opening paragraphs, style consistency (#…
f4d4168 
…5737)

Add F5 prefix to configuration opening paragraphs, style consistency

This commit changes each of the opening paragraphs of the Configuration
section to ensure they have the F5 prefixed name for the first instance
of NGINX Ingress Controller.

It also includes a large amount of other changes:

- Relative links
- Erroneous product names ("the Ingress Controller")
- Contemporary table formatting
- Updated and decoupled input/output code blocks
- Sentence case for page titles and headings
- Small contextual rewrites
- Updated links to appropriate tags

A small number of unrelated changes were also included, regarding NGINX
App Protect and a small typo in a command line option.

Signed-off-by: Alan Dooley <[email protected]>
Co-authored-by: Venktesh Shivam Patel <[email protected]>
@nginx-bot @pdabelf5
Docker image update d41d8cd9 (#5743)
2028376
@pdabelf5
add release workflow (#5742)
9f37c5f
@pdabelf5
Merge branch 'main' into workflow-refactor
d7cec6a
@github-actions github-actions bot added github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels Jun 17, 2024
@github-actions github-actions bot added the docker Pull requests that update Docker code label Jun 18, 2024
@github-actions github-actions bot added the tests Pull requests that update tests label Jun 18, 2024
@pdabelf5 pdabelf5 marked this pull request as ready for review June 18, 2024 15:01
@pdabelf5 pdabelf5 requested a review from a team as a code owner June 18, 2024 15:01
@oseoin oseoin linked an issue Jun 18, 2024 that may be closed by this pull request
create workflow for releasing images #5134
Closed
@pdabelf5 pdabelf5 merged commit 131e784 into main Jun 19, 2024
80 checks passed
@pdabelf5 pdabelf5 deleted the workflow-refactor branch June 19, 2024 08:12
ssrahul96 pushed a commit to ssrahul96/kubernetes-ingress that referenced this pull request Jun 20, 2024
@pdabelf5 @ssrahul96
Workflow refactor (nginx#5766)
8e531b3
This was referenced Jul 1, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjngx jjngx jjngx approved these changes

@vepatel vepatel vepatel approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@oseoin oseoin oseoin approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks docker Pull requests that update Docker code github_actions Pull requests that update Github_actions code tests Pull requests that update tests
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create workflow for releasing images
9 participants
@pdabelf5 @oseoin @j1m-ryan @vepatel @jjngx @pasmant @shaun-nx @ADubhlaoich @nginx-bot