Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add grpc example #5699

Merged
merged 9 commits into from
Jun 6, 2024
Merged

Add grpc example #5699

merged 9 commits into from
Jun 6, 2024

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Jun 6, 2024 •
edited
Loading

Proposed changes

  • Add virtual-server grpc example

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner June 6, 2024 10:31
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jun 6, 2024
@vepatel vepatel requested a review from ADubhlaoich June 6, 2024 10:31
@vepatel vepatel linked an issue Jun 6, 2024 that may be closed by this pull request
Add grpc example to NIC repo #5634
Closed
ADubhlaoich
ADubhlaoich approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM generally: edit suggestions for nouns, punctuation and tone.

examples/custom-resources/grpc-upstreams/README.md Outdated Show resolved Hide resolved
examples/custom-resources/grpc-upstreams/README.md Outdated Show resolved Hide resolved
examples/custom-resources/grpc-upstreams/README.md Outdated Show resolved Hide resolved
examples/custom-resources/grpc-upstreams/README.md Outdated Show resolved Hide resolved
examples/custom-resources/grpc-upstreams/README.md Outdated Show resolved Hide resolved
examples/custom-resources/grpc-upstreams/README.md Outdated Show resolved Hide resolved
examples/custom-resources/grpc-upstreams/README.md Outdated Show resolved Hide resolved
vepatel and others added 8 commits June 6, 2024 15:45
@vepatel @ADubhlaoich
add review suggestion
2b1f1e7 
Co-authored-by: Alan Dooley <[email protected]>
Signed-off-by: Venktesh Shivam Patel <[email protected]>
@vepatel @ADubhlaoich
add review suggestion
4d0306e 
Co-authored-by: Alan Dooley <[email protected]>
Signed-off-by: Venktesh Shivam Patel <[email protected]>
@vepatel @ADubhlaoich
add review suggestion
9f75600 
Co-authored-by: Alan Dooley <[email protected]>
Signed-off-by: Venktesh Shivam Patel <[email protected]>
@vepatel @ADubhlaoich
add review suggestion
d7e5001 
Co-authored-by: Alan Dooley <[email protected]>
Signed-off-by: Venktesh Shivam Patel <[email protected]>
@vepatel @ADubhlaoich
add review suggestion
ed6e357 
Co-authored-by: Alan Dooley <[email protected]>
Signed-off-by: Venktesh Shivam Patel <[email protected]>
@vepatel @ADubhlaoich
add review suggestion
fc429ee 
Co-authored-by: Alan Dooley <[email protected]>
Signed-off-by: Venktesh Shivam Patel <[email protected]>
@vepatel @ADubhlaoich
add review suggestion
ff33198 
Co-authored-by: Alan Dooley <[email protected]>
Signed-off-by: Venktesh Shivam Patel <[email protected]>
@vepatel
Merge branch 'main' into chore/add-grpc-example
3339fa6
@vepatel vepatel merged commit f37f598 into main Jun 6, 2024
28 checks passed
@vepatel vepatel deleted the chore/add-grpc-example branch June 6, 2024 15:14
ssrahul96 pushed a commit to ssrahul96/kubernetes-ingress that referenced this pull request Jun 20, 2024
@vepatel @ssrahul96
Add grpc example (nginx#5699)
abdd84a
This was referenced Jul 1, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjngx jjngx jjngx approved these changes

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add grpc example to NIC repo
3 participants
@vepatel @ADubhlaoich @jjngx