Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test reducing size of UBI NAP images #5613

Merged
merged 16 commits into from
Jun 10, 2024
Merged

Test reducing size of UBI NAP images #5613

merged 16 commits into from
Jun 10, 2024

Conversation

oseoin
Copy link
Contributor

@oseoin oseoin commented May 24, 2024 •
edited
Loading

Proposed changes

Sample of size reductions:

Image Before After Reduction
Alpine OSS 181MB 127MB ~30%
Alpine Plus 161MB 114MB ~29%
Debian OSS 332MB 279MB ~16%
Debian Plus 284MB 231MB ~18%
UBI NAP 1.29GB 977MB ~23%

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the docker Pull requests that update Docker code label May 24, 2024
@oseoin oseoin marked this pull request as ready for review May 28, 2024 13:46
@oseoin oseoin requested a review from a team as a code owner May 28, 2024 13:46
@oseoin oseoin merged commit 64cfcc4 into main Jun 10, 2024
81 checks passed
@oseoin oseoin deleted the test-trim-images branch June 10, 2024 13:04
ssrahul96 pushed a commit to ssrahul96/kubernetes-ingress that referenced this pull request Jun 20, 2024
@oseoin @ssrahul96
Reduce size of final built images (nginx#5613)
c852487
This was referenced Jul 1, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdabelf5 pdabelf5 pdabelf5 approved these changes

@jjngx jjngx jjngx approved these changes

Assignees
No one assigned
Labels
docker Pull requests that update Docker code
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oseoin @jjngx @pdabelf5