Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release namespace to all helm charts #555

Merged
merged 1 commit into from
May 7, 2019
Merged

Add release namespace to all helm charts #555

merged 1 commit into from
May 7, 2019

Conversation

Rulox
Copy link
Contributor

@Rulox Rulox commented May 2, 2019

Proposed changes

This request came from another Pull Request #546 (comment)

Add the Release.Namespace as the metadata.namespace in all of the Helm charts.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Rulox Rulox added the enhancement Pull requests for new features/feature enhancements label May 2, 2019
@Rulox Rulox requested a review from pleshakov May 2, 2019 09:00
@Rulox Rulox self-assigned this May 2, 2019
pleshakov
pleshakov approved these changes May 3, 2019
View reviewed changes
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

deployments/helm-chart/templates/rbac.yaml Outdated Show resolved Hide resolved
@Rulox Rulox force-pushed the helm-namespace branch from 3541f78 to 22cba6e Compare May 3, 2019 16:15
@Rulox Rulox force-pushed the helm-namespace branch from 22cba6e to 008e01d Compare May 3, 2019 16:15
martialonline
martialonline approved these changes May 7, 2019
View reviewed changes
Copy link
Contributor

@martialonline martialonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Rulox Rulox merged commit a8a3ed3 into master May 7, 2019
@Rulox Rulox deleted the helm-namespace branch May 7, 2019 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martialonline martialonline martialonline approved these changes

@pleshakov pleshakov pleshakov approved these changes

Assignees

@Rulox Rulox

Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rulox @pleshakov @martialonline