Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable logging in tests #5499

Merged
merged 10 commits into from
May 3, 2024
Merged

enable logging in tests #5499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
af8bdb1
test
haywoodsh May 2, 2024
c2db326
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 2, 2024
168c2f0
Merge branch 'main' into chore/pipeline
pdabelf5 May 3, 2024
e897909
revert tests
vepatel May 3, 2024
6f3c13d
Merge branch 'main' into chore/pipeline
vepatel May 3, 2024
07d1054
print headers
vepatel May 3, 2024
98acb94
print test and pod logs
vepatel May 3, 2024
d300a17
typo
vepatel May 3, 2024
68cc58e
Merge branch 'main' into chore/pipeline
vepatel May 3, 2024
d36fad7
remove prints
vepatel May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/actions/smoke-tests/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ runs:
--durations=10 \
--show-ic-logs=yes \
--ad-secret=${{ inputs.azure-ad-secret }} \
-m ${{ inputs.marker != '' && inputs.marker || '""' }}
-m ${{ inputs.marker != '' && inputs.marker || '""' }} \
-v \
-s
working-directory: ./tests
shell: bash
2 changes: 1 addition & 1 deletion tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ def pytest_runtest_makereport(item) -> None:
rep = outcome.get_result()

# we only look at actual failing test calls, not setup/teardown
if rep.when == "call" and rep.failed and item.config.getoption("--show-ic-logs") == "yes":
if rep.when == "call" and item.config.getoption("--show-ic-logs") == "yes":
pod_namespace = item.funcargs["ingress_controller_prerequisites"].namespace
pod_name = get_first_pod_name(item.funcargs["kube_apis"].v1, pod_namespace)
print("\n===================== IC Logs Start =====================")
Expand Down
Loading