-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect count of secrets #5404
Merged
Merged
Collect count of secrets #5404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Pull requests/issues for documentation
helm_chart
Pull requests that update the Helm Chart
labels
Apr 16, 2024
j1m-ryan
reviewed
Apr 16, 2024
j1m-ryan
reviewed
Apr 16, 2024
j1m-ryan
approved these changes
Apr 16, 2024
jjngx
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Pull requests/issues for documentation
go
Pull requests that update Go code
helm_chart
Pull requests that update the Helm Chart
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change updates the telemetry collector to count the number of Secret resources managed by the Ingress Controller.
This change makes updates to our local Secret store to allow access to the secret reference map. This ensures we only count secrets that are watched and managed by NIC (i.e. it will exclude secrets that we explicitly ignore and secrets that are not in a watched namespace)
Additional changes
values.yaml
main.go
and update some commentsChecklist
Before creating a PR, run through this checklist and mark each as complete.