Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure minimum of protobuf 1.33.0 #5384

Merged
merged 4 commits into from
Apr 15, 2024
Merged

ensure minimum of protobuf 1.33.0 #5384

merged 4 commits into from
Apr 15, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Apr 12, 2024 •
edited
Loading

Proposed changes

Replace older version of protobuf with 1.33.0

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner April 12, 2024 14:16
@github-actions github-actions bot added dependencies Pull requests that update a dependency file tests Pull requests that update tests labels Apr 12, 2024
@pdabelf5 pdabelf5 removed the tests Pull requests that update tests label Apr 15, 2024
@pdabelf5 pdabelf5 added the go Pull requests that update Go code label Apr 15, 2024
@pdabelf5 pdabelf5 merged commit bc04644 into main Apr 15, 2024
75 of 80 checks passed
@pdabelf5 pdabelf5 deleted the security/update-protobuf branch April 15, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaun-nx shaun-nx shaun-nx approved these changes

@jjngx jjngx jjngx approved these changes

@vepatel vepatel vepatel approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pdabelf5 @vepatel @jjngx @shaun-nx