Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Choose NodePort values for controller.service.type = LoadBalancer #5335

Merged
merged 6 commits into from
Jul 18, 2024
Merged

Choose NodePort values for controller.service.type = LoadBalancer #5335

merged 6 commits into from
Jul 18, 2024
+6 −6

Conversation

Falltrades
Copy link
Contributor

@Falltrades Falltrades commented Apr 2, 2024 •
edited
Loading

Proposed changes

Closes related issue: #5333

This changes enable the possibility to choose custom NodePort port values when for controller.service.type = LoadBalancer.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@Falltrades Falltrades requested a review from a team as a code owner April 2, 2024 19:27
@netlify Netlify
Copy link

netlify bot commented Apr 2, 2024 •
edited
Loading

👷 Deploy request for nginx-kubernetes-ingress pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 4bb9882

@github-actions github-actions bot added documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart labels Apr 2, 2024
@brianehlert brianehlert linked an issue Apr 8, 2024 that may be closed by this pull request
[Helm] Choose NodePort values for controller.service.type = LoadBalancer #5333
Closed
@vepatel
Copy link
Contributor

vepatel commented Jul 18, 2024 •
edited
Loading

Hey @Falltrades this PR will be merged hopefully today but just a suggestion on branching please create a branch in the forked repo instead of using main for development for future contributions.

thanks again for the PR and apologies for the delay

@vepatel vepatel enabled auto-merge (squash) July 18, 2024 14:09
@vepatel vepatel merged commit 2e5fd64 into nginx:main Jul 18, 2024
109 of 143 checks passed
@pdabelf5 pdabelf5 removed the documentation Pull requests/issues for documentation label Sep 23, 2024
@pdabelf5 pdabelf5 changed the title [Helm] Choose NodePort values for controller.service.type = LoadBalancer Choose NodePort values for controller.service.type = LoadBalancer Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@vepatel vepatel vepatel approved these changes

Assignees
No one assigned
Labels
helm_chart Pull requests that update the Helm Chart
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Helm] Choose NodePort values for controller.service.type = LoadBalancer
4 participants
@Falltrades @vepatel @AlexFenlon @pdabelf5