Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct helm version in docs #5287

Merged
merged 2 commits into from
Mar 21, 2024
Merged

correct helm version in docs #5287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8570cb
correct helm version in docs
pdabelf5 Mar 21, 2024
9ce7301
Merge branch 'main' into docs/fix-helm-version
pdabelf5 Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions charts/nginx-ingress/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,14 +87,14 @@ To install the chart with the release name my-release (my-release is the name th
For NGINX:

```console
helm install my-release oci://ghcr.io/nginxinc/charts/nginx-ingress --version 1.1.2
helm install my-release oci://ghcr.io/nginxinc/charts/nginx-ingress --version 1.1.3
```

For NGINX Plus: (assuming you have pushed the Ingress Controller image `nginx-plus-ingress` to your private registry
`myregistry.example.com`)

```console
helm install my-release oci://ghcr.io/nginxinc/charts/nginx-ingress --version 1.1.2 --set controller.image.repository=myregistry.example.com/nginx-plus-ingress --set controller.nginxplus=true
helm install my-release oci://ghcr.io/nginxinc/charts/nginx-ingress --version 1.1.3 --set controller.image.repository=myregistry.example.com/nginx-plus-ingress --set controller.nginxplus=true
```

This will install the latest `edge` version of the Ingress Controller from GitHub Container Registry. If you prefer to
Expand All @@ -109,7 +109,7 @@ CRDs](#upgrading-the-crds).
To upgrade the release `my-release`:

```console
helm upgrade my-release oci://ghcr.io/nginxinc/charts/nginx-ingress --version 1.1.2
helm upgrade my-release oci://ghcr.io/nginxinc/charts/nginx-ingress --version 1.1.3
```

### Uninstalling the Chart
Expand Down Expand Up @@ -150,7 +150,7 @@ upgrading/deleting the CRDs.
1. Pull the chart sources:

```console
helm pull oci://ghcr.io/nginxinc/charts/nginx-ingress --untar --version 1.1.2
helm pull oci://ghcr.io/nginxinc/charts/nginx-ingress --untar --version 1.1.3
```

2. Change your working directory to nginx-ingress:
Expand Down
8 changes: 4 additions & 4 deletions docs/content/installation/installing-nic/installation-with-helm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,13 @@ To install the chart with the release name my-release (my-release is the name th
- For NGINX:

```shell
helm install my-release oci://ghcr.io/nginxinc/charts/nginx-ingress --version 1.1.2
helm install my-release oci://ghcr.io/nginxinc/charts/nginx-ingress --version 1.1.3
```

- For NGINX Plus: (assuming you have pushed the Ingress Controller image `nginx-plus-ingress` to your private registry `myregistry.example.com`)

```shell
helm install my-release oci://ghcr.io/nginxinc/charts/nginx-ingress --version 1.1.2 --set controller.image.repository=myregistry.example.com/nginx-plus-ingress --set controller.nginxplus=true
helm install my-release oci://ghcr.io/nginxinc/charts/nginx-ingress --version 1.1.3 --set controller.image.repository=myregistry.example.com/nginx-plus-ingress --set controller.nginxplus=true
```

This will install the latest `edge` version of the Ingress Controller from GitHub Container Registry. If you prefer to use Docker Hub, you can replace `ghcr.io/nginxinc/charts/nginx-ingress` with `registry-1.docker.io/nginxcharts/nginx-ingress`.
Expand All @@ -92,7 +92,7 @@ Helm does not upgrade the CRDs during a release upgrade. Before you upgrade a re
To upgrade the release `my-release`:

```shell
helm upgrade my-release oci://ghcr.io/nginxinc/charts/nginx-ingress --version 1.1.2
helm upgrade my-release oci://ghcr.io/nginxinc/charts/nginx-ingress --version 1.1.3
```

### Uninstalling the Chart
Expand Down Expand Up @@ -129,7 +129,7 @@ This step is required if you're installing the chart using its sources. Addition
1. Pull the chart sources:

```shell
helm pull oci://ghcr.io/nginxinc/charts/nginx-ingress --untar --version 1.1.2
helm pull oci://ghcr.io/nginxinc/charts/nginx-ingress --untar --version 1.1.3
```

2. Change your working directory to nginx-ingress:
Expand Down
2 changes: 1 addition & 1 deletion docs/content/installation/nic-images/using-the-jwt-token-docker-secret.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ If the namespace does not exist, `--create-namespace` will create it. Using `-f
If you want to install NGINX Ingress Controller using the charts method, the following is an example of using the command line to pass the required arguments using the `set` parameter.

```shell
helm install my-release -n nginx-ingress oci://ghcr.io/nginxinc/charts/nginx-ingress --version 1.1.2 --set controller.image.repository=private-registry.nginx.com/nginx-ic/nginx-plus-ingress --set controller.image.tag=3.4.3 --set controller.nginxplus=true --set controller.serviceAccount.imagePullSecretName=regcred
helm install my-release -n nginx-ingress oci://ghcr.io/nginxinc/charts/nginx-ingress --version 1.1.3 --set controller.image.repository=private-registry.nginx.com/nginx-ic/nginx-plus-ingress --set controller.image.tag=3.4.3 --set controller.nginxplus=true --set controller.serviceAccount.imagePullSecretName=regcred
```
You can also use the certificate and key from the MyF5 portal and the Docker registry API to list the available image tags for the repositories, for example:

Expand Down
Loading