update version to 3.4.3 #5128
Merged
update version to 3.4.3 #5128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
jjngx
approved these changes
Feb 19, 2024
vepatel
approved these changes
Feb 19, 2024
oseoin
approved these changes
Feb 20, 2024
sigv
reviewed
Mar 8, 2024
| @@ -150,7 +150,7 @@ If the namespace does not exist, `--create-namespace` will create it. Using `-f | |||
| If you want to install NGINX Ingress Controller using the charts method, the following is an example of using the command line to pass the required arguments using the `set` parameter. | |||
|
|
|||
| ```shell | |||
| helm install my-release -n nginx-ingress oci://ghcr.io/nginxinc/charts/nginx-ingress --version 1.1.2 --set controller.image.repository=private-registry.nginx.com/nginx-ic/nginx-plus-ingress --set controller.image.tag=3.4.2 --set controller.nginxplus=true --set controller.serviceAccount.imagePullSecretName=regcred | |||
| helm install my-release -n nginx-ingress oci://ghcr.io/nginxinc/charts/nginx-ingress --version 1.1.2 --set controller.image.repository=private-registry.nginx.com/nginx-ic/nginx-plus-ingress --set controller.image.tag=3.4.3 --set controller.nginxplus=true --set controller.serviceAccount.imagePullSecretName=regcred | |||
There was a problem hiding this comment.
This line still references Helm chart --version 1.1.2 although release 3.4.3 is expected to be used via chart version 1.1.3.
Similarly, charts/nginx-ingress/README.md L90 can be observed as missing a replacement.
However, docs/content/technical-specifications.md was updated (by hand?).
What's strange to me with this is that helm pull oci://ghcr.io/nginxinc/charts/nginx-ingress --untar --version 1.1.3 produces an nginx-ingress/README.md where 1.1.3 is mentioned.
There was a problem hiding this comment.
@sigv great catch we appreciate it. We are going to fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
update version to 3.4.3
Checklist
Before creating a PR, run through this checklist and mark each as complete.