Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing platforms in base image build #5017

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Add missing platforms in base image build #5017

merged 2 commits into from
Jan 31, 2024

Conversation

oseoin
Copy link
Contributor

@oseoin oseoin commented Jan 31, 2024

Proposed changes

Base images currently only build amd64 images, platform flag is needed to cover other architectures.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@oseoin oseoin requested a review from a team as a code owner January 31, 2024 15:04
@oseoin oseoin merged commit e996860 into main Jan 31, 2024
52 checks passed
@oseoin oseoin deleted the base-image-platforms branch January 31, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdabelf5 pdabelf5 pdabelf5 approved these changes

@vepatel vepatel vepatel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oseoin @vepatel @pdabelf5