Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 4837: chore: Rename main_test.go to flags_test.go #5015

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

mrajagopal
Copy link
Contributor

@mrajagopal mrajagopal commented Jan 31, 2024

  • All the tests contained are for flags.go functions anyway
  • Therefore, it makes sense to rename the test file as such

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@mrajagopal mrajagopal requested a review from a team as a code owner January 31, 2024 04:44
Copy link

netlify bot commented Jan 31, 2024

👷 Deploy request for nginx-kubernetes-ingress pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 6bb3949

@mrajagopal
Copy link
Contributor Author

mrajagopal commented Jan 31, 2024

This CI job for checks and variables on my forked branch fails.

Run cd ../.. && mkdir -p github.com/nginxinc && mv kubernetes-ingress/kubernetes-ingress github.com/nginxinc/ && cd github.com/nginxinc/kubernetes-ingress mv: cannot stat 'kubernetes-ingress/kubernetes-ingress': No such file or directory make: *** No rule to make target 'update-codegen'. Stop. mv: cannot stat 'github.com/nginxinc/kubernetes-ingress': No such file or directory Error: Process completed with exit code 1.

I think the job doesn't account for forks.
This has resulted in rest of the CI jobs to be skipped.

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8a2c9a9) 52.32% compared to head (9082900) 52.34%.
Report is 1 commits behind head on main.

❗ Current head 9082900 differs from pull request most recent head 6bb3949. Consider uploading reports for the commit 6bb3949 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5015      +/-   ##
==========================================
+ Coverage   52.32%   52.34%   +0.02%     
==========================================
  Files          61       61              
  Lines       17502    17502              
==========================================
+ Hits         9158     9162       +4     
+ Misses       8015     8013       -2     
+ Partials      329      327       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5
Copy link
Collaborator

pdabelf5 commented Feb 1, 2024

This CI job for checks and variables on my forked branch fails.

Run cd ../.. && mkdir -p github.com/nginxinc && mv kubernetes-ingress/kubernetes-ingress github.com/nginxinc/ && cd github.com/nginxinc/kubernetes-ingress mv: cannot stat 'kubernetes-ingress/kubernetes-ingress': No such file or directory make: *** No rule to make target 'update-codegen'. Stop. mv: cannot stat 'github.com/nginxinc/kubernetes-ingress': No such file or directory Error: Process completed with exit code 1.

I think the job doesn't account for forks. This has resulted in rest of the CI jobs to be skipped.

The failure happened due to the actions running in your fork, outside the context of this repo. This job passed in the PR pipeline.

@haywoodsh haywoodsh linked an issue Feb 1, 2024 that may be closed by this pull request
* All the tests contained were for flags.go functions anyway
* Therefore, it makes sense to rename it as such.
@mrajagopal mrajagopal force-pushed the mrajagopal-issue-4837 branch from 9082900 to 6bb3949 Compare February 1, 2024 22:58
@pdabelf5 pdabelf5 merged commit 558b34e into nginx:main Feb 2, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor main_test.go and add more coverage for main.go
3 participants