-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 4837: chore: Rename main_test.go to flags_test.go #5015
Conversation
👷 Deploy request for nginx-kubernetes-ingress pending review.Visit the deploys page to approve it
|
This CI job for
I think the job doesn't account for forks. |
067446f
to
6c9d43b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5015 +/- ##
==========================================
+ Coverage 52.32% 52.34% +0.02%
==========================================
Files 61 61
Lines 17502 17502
==========================================
+ Hits 9158 9162 +4
+ Misses 8015 8013 -2
+ Partials 329 327 -2 ☔ View full report in Codecov by Sentry. |
The failure happened due to the actions running in your fork, outside the context of this repo. This job passed in the PR pipeline. |
* All the tests contained were for flags.go functions anyway * Therefore, it makes sense to rename it as such.
9082900
to
6bb3949
Compare
flags.go
functions anywayProposed changes
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to
that issue here in this description (not in the title of the PR).
Checklist
Before creating a PR, run through this checklist and mark each as complete.