-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build base images for OSS #4999
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4999 +/- ##
==========================================
- Coverage 52.31% 52.28% -0.03%
==========================================
Files 60 60
Lines 17501 17501
==========================================
- Hits 9155 9151 -4
- Misses 8018 8020 +2
- Partials 328 330 +2 ☔ View full report in Codecov by Sentry. |
pdabelf5
approved these changes
Jan 30, 2024
jjngx
approved these changes
Jan 30, 2024
vepatel
approved these changes
Jan 30, 2024
j1m-ryan
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Builds the
common
target for each OS/flavour which will be consumed in a later PR. This will avoid rebuilding the same layers for each new branch and should reduce cache usage (and hopefully reduce cache 429s as a result). The tags used include a trimmed version of the hash of the dockerfile + version file, which means that any branch consuming these images will use the correct version for the current state of the branch.This has been tested with a manual trigger of the workflow, which resulted in the following images being built and stored:
This PR also renames
alpine-plus-nap-waf-fips
toalpine-plus-nap-fips
for consistency - this is only used internally and will not impact the name of released images.Checklist
Before creating a PR, run through this checklist and mark each as complete.