Put configuration of ldflags closer to top of makefile #4880
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
ldflags
provide us with a means to inject values at build time.We currently use this to inject the version of NIC. Overtime we can expand this to add more data as we see fit.
This change simply makes adding additional
ldflags
more user friendly by making the configuration more obvious and easier to expand.Checklist
Before creating a PR, run through this checklist and mark each as complete.