move pod label update to goroutine with retries #4835
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Behaviour when can't get pod after max attempts:
Behaviour when can't get pod for first N attempts and then succeeds:
Behaviour when can't update pod for first N attempts and then succeeds:
Confirmed that labels are updated correctly after failures.
This also takes the update out of the hot path so should slightly reduce startup time.
Checklist
Before creating a PR, run through this checklist and mark each as complete.