fix new lines in snippets #4832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for nginx-kubernetes-ingress pending review.Visit the deploys page to approve it
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4832 +/- ##
==========================================
- Coverage 52.13% 52.10% -0.03%
==========================================
Files 60 60
Lines 17368 17368
==========================================
- Hits 9054 9050 -4
- Misses 8000 8002 +2
- Partials 314 316 +2 ☔ View full report in Codecov by Sentry. |
oseoin
approved these changes
Dec 21, 2023
pdabelf5
approved these changes
Dec 21, 2023
vepatel
approved these changes
Dec 21, 2023
|
Thank you for the fast response! |
5 tasks
pdabelf5
pushed a commit
that referenced
this pull request
Feb 9, 2024
* fix new lines in snippets * add test for server snippet new lines * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
pdabelf5
added a commit
that referenced
this pull request
Feb 9, 2024
* fix new lines in snippets (#4832)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
#4824
Fixes server snippet new lines issue in vservers and transport servers by including a new line in the tmpl files
Checklist
Before creating a PR, run through this checklist and mark each as complete.