-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ports customisation options for ingress controller service. #479
Add ports customisation options for ingress controller service. #479
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Just some small changes for consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. Looks like you missed a few small things. Happy to merge once these are resolved.
Could you possibly squash your commits into one commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Proposed changes
Add needed parameters to helm chart in orders to use custom options for the follow features:
Notes
Take into account the
port
spec inhttpPort|httpsPort
withinvalues.yaml
must match the container ports in the deployment|daemonset; another option would be add parametrizedtargetPort
to thevalues.yaml
and modify subsequents yaml files likecontroller-deployment.yaml
andcontroller-daemonset.yaml
.Checklist
Before creating a PR, run through this checklist and mark each as complete.