fix: address security concerns #4681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the "Harden Runner" step to all CI jobs, this should help point out the required rules for egress traffic. This can be changed to block all egress with a whitelist of allowed domains in future.
for more information, see https://pre-commit.ci
pdabelf5
added
enhancement
Closed
github-actions
bot
removed
the
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4681 +/- ##
==========================================
+ Coverage 52.08% 52.10% +0.02%
==========================================
Files 59 59
Lines 17033 17033
==========================================
+ Hits 8871 8875 +4
+ Misses 7862 7860 -2
+ Partials 300 298 -2 ☔ View full report in Codecov by Sentry. |
lucacome
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add the "Harden Runner" step to all CI jobs, this should help point out
the required rules for egress traffic. This can be changed to block
all egress with a whitelist of allowed domains in future.
Address scope of GITHUB_TOKEN in release Pull request action
Checklist
Before creating a PR, run through this checklist and mark each as complete.