Support weights 0 and 100 in traffic splitting #4655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4655 +/- ##
==========================================
- Coverage 51.93% 51.92% -0.01%
==========================================
Files 59 59
Lines 16972 16973 +1
==========================================
- Hits 8814 8813 -1
- Misses 7861 7862 +1
- Partials 297 298 +1 ☔ View full report in Codecov by Sentry. |
jjngx
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
🚀
@haywoodsh could you add description to the Proposed Changes section?
shaun-nx
reviewed
Nov 15, 2023
Signed-off-by: Haywood Shannon <[email protected]>
Signed-off-by: Haywood Shannon <[email protected]>
haywoodsh
force-pushed
the
feat/support-traffic-splitting-with-weights-0-100
branch
from
2c669e8 to
227ddfb
Compare
shaun-nx
approved these changes
Nov 20, 2023
haywoodsh
deleted the
feat/support-traffic-splitting-with-weights-0-100
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Allow split traffic's weight value in virtual server to be 0% or 100%.
This change is proposed because "0%" is not currently a valid syntax in
split_clients. When the value is set to 0%, it will not be included in the generated config, but the effect will be the same as if it were. A value of 100% enables full traffic routing to a particular upstream.Checklist
Before creating a PR, run through this checklist and mark each as complete.