Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing app-protect maskValueInLogs and useXmlResponsePage #4638

Closed
wants to merge 2 commits into from

Conversation

schweits
Copy link

Proposed changes

  • Added the missing maskValueInLogs to cookies for app-protect
  • Added the missing useXmlResponsePage to xml-profiles for app-protect

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@schweits schweits requested a review from a team as a code owner November 13, 2023 12:22
@brianehlert brianehlert added this to the v3.4.0 milestone Nov 13, 2023
@brianehlert brianehlert added the backlog Pull requests/issues that are backlog items label Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #4638 (79bbac6) into main (838a0e4) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4638      +/-   ##
==========================================
+ Coverage   51.96%   51.98%   +0.01%     
==========================================
  Files          59       59              
  Lines       16960    16960              
==========================================
+ Hits         8814     8816       +2     
+ Misses       7849     7847       -2     
  Partials      297      297              

see 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@schweits
Copy link
Author

Handled in #4640

@schweits schweits closed this Nov 13, 2023
@schweits schweits deleted the patch-1 branch November 13, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Pull requests/issues that are backlog items
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants