-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review, restructure and rewrite documentation for getting started with NGINX Ingress Controller #4620
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4620 +/- ##
==========================================
+ Coverage 51.96% 51.99% +0.02%
==========================================
Files 59 59
Lines 16960 16960
==========================================
+ Hits 8814 8818 +4
+ Misses 7849 7847 -2
+ Partials 297 295 -2 ☔ View full report in Codecov by Sentry. |
Fix version numbers in revamp branch
PR almost ready for full review - fixing some additional errant artifacts of git merging. Looks as though some API versioning and the docs themselves under |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This isn't up to date, and thus should not be published.
Everything should be good now - also included a small bandaid "fix" for something I noticed in a security configuration file. |
docs/content/installation/installing-nic/installation-with-manifests.md
Outdated
Show resolved
Hide resolved
Please ignore my blocking change. I made a comment about the wrong section of the document 🤦 |
…ifests.md Co-authored-by: Shaun <[email protected]> Signed-off-by: Alan Dooley <[email protected]>
for more information, see https://pre-commit.ci
Lets just make sure we don't block the docs team. |
…h NGINX Ingress Controller (#4620)
…h NGINX Ingress Controller (#4620)
…h NGINX Ingress Controller (#4620)
…h NGINX Ingress Controller (#4620)
Proposed changes
This pull request represents a large collection of work to improve the NGINX Ingress Controller documentation by restructuring the layout of "onboarding" documentation, then digging deep into individual pages to address certain issues.
The scope of changes includes:
The driving force behind these changes is to make the overall user experience for people engaging with NGINX Ingress Controller for the first time to have a smoother onboarding experience. There will be subsequent requests for the documentation following this idea.
Checklist
Before creating a PR, run through this checklist and mark each as complete.