-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update use of http2 listen directive to align with deprecation #4526
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4526 +/- ##
==========================================
- Coverage 52.00% 51.98% -0.02%
==========================================
Files 59 59
Lines 16965 16965
==========================================
- Hits 8822 8820 -2
- Misses 7848 7850 +2
Partials 295 295 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Hi, is this PR included in v3.3.2? I've upgraded my ingress to v3.3.2 and got the warning, I can't see the PR on the release page. So this is not released yet, right? |
Hi @hanyouqing this is included in v3.4.0 which is released today 👍🏼 |
Proposed changes
As of NGINX 1.25.1, the
http2
option for the listen directive has been deprecated.This change updates our main NGINX, VirtualServer and Ingress templates to enable the new http2 directive in NGINX.
Change this:
To this:
Resolves #4237
Checklist
Before creating a PR, run through this checklist and mark each as complete.