-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prevent pip to look for dependency during install #4342
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4342 +/- ##
==========================================
- Coverage 52.11% 52.08% -0.03%
==========================================
Files 59 59
Lines 16956 16956
==========================================
- Hits 8836 8832 -4
- Misses 7823 7825 +2
- Partials 297 299 +2 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Why do we want this? We don't want to use hashes? |
@lucacome its looking for hashes of indirect dependencies during install sometimes, there's an pypi issue as well for this see the linked issue and pipeline failure for more details. We can revert this change once it's fixed. |
I feel like we should figure out why it only happens sometimes before disabling it. It kind of defeats the purpose of the hashes if we don't check them... |
more than happy to remove hashes and go back to old way of pinning libs actually used by tests. Not sure what we can do if the issue is in pypi impementation. |
Proposed changes
Checklist
Before creating a PR, run through this checklist and mark each as complete.